Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic unit tests (try tinytest?) #316

Closed
PMassicotte opened this issue Sep 25, 2019 · 8 comments
Closed

Add basic unit tests (try tinytest?) #316

PMassicotte opened this issue Sep 25, 2019 · 8 comments

Comments

@PMassicotte
Copy link
Owner

  • Try the tinytest package cc @eddelbuettel (will need some help to configure Travis).
@eddelbuettel
Copy link
Collaborator

Sure. Now ... what would we test? The data does not stay the same...

@PMassicotte
Copy link
Owner Author

PMassicotte commented Sep 25, 2019

Very simple stuff:
1 - Returned df's are not empty
2 - Non-ascii keywords are not changed (encoding issues)

I just created a branch for it.

@eddelbuettel
Copy link
Collaborator

Ok. The .travis.yml should be straightforward for Linux as we get our for depends pre-built. (I do use a format that works well for me, but that not everybody else uses. Don't mean to impose it; happy to help with it. I can be extended to test on macOS too but I usually do not bother and just stick to Linux.)

Simple tests like that should be simple indeed.

@PMassicotte
Copy link
Owner Author

Should good to me :) Just exploring the package now, looks good!

@PMassicotte
Copy link
Owner Author

I have added few tests, feel free to add .travis.yml. Thanks in advance.

@eddelbuettel
Copy link
Collaborator

eddelbuettel commented Sep 26, 2019

Looks complete, just append r-cran-tinytest to line 14 in .travis.yml so that tinytest is present. It is in the Rutter PPAs we use.

@eddelbuettel
Copy link
Collaborator

Yay!! (And that last step is the main annoyance with the simpler-yet-more-predictable approach I use -- it does not "learn" from DESCRIPTION so when you change Imports: or Suggests: you must change .travis.yml as well. Have forgotten it a dozen times myself ...)

@PMassicotte
Copy link
Owner Author

PMassicotte commented Sep 26, 2019

That makes sense, I will try to remember :)

PMassicotte added a commit that referenced this issue Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants