Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this opts out of all four test files unless opted in #384

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

eddelbuettel
Copy link
Collaborator

This PR is a little radical in that all tests are now conditional on being explicitly opted in via a new environment variable.

This may help at CRAN. The curl issue seems random and even hit me here but was easily fixed by a re-run. This may be an issue in curl, seen "randomly" at at least the CRAN Debian machine and here under ubuntu-latest.

I am wondering if you should add a simple "lighter" unit test file with something not involving a curl call so that we always have "something" to run?

Also, if you merge the previous PR I can rebase it in here so that this PR gets the benefit of the tests.

@PMassicotte
Copy link
Owner

I like the way you implemented it. I also ran into random errors, even on my own machine.

I am wondering if you should add a simple "lighter" unit test file with something not involving a curl call so that we always have "something" to run?

Are you thinking about something specifically? I can not think to a test not involving curl right now. I will open an issue where I will trow out ideas when they come.

@PMassicotte PMassicotte merged commit b3e3bf5 into master Feb 21, 2021
@eddelbuettel eddelbuettel deleted the feature/conditional_tests branch June 10, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants