Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly bind logging procs in templates #168

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Explicitly bind logging procs in templates #168

merged 2 commits into from
Sep 30, 2023

Commits on Sep 29, 2023

  1. Explicitly bind logging procs in templates 

    The logging templates in `logger` reference procs like `error`, `info`, `warn` etc. from the `logging` module. These are implicitly bound, as they have exactly 1 overload in the scope of the template definitions (nim-lang/Nim#11184).

If this behavior of Nim or the context in `logger` were to change, these would start preferring procs like `macros.error` instead and cause issues. Explicitly binding them keeps the current behavior consistent.

An alternative would be to directly call `logging.error join(args)` etc.
    @metagn
    metagn authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    6451ef6 View commit details
    Browse the repository at this point in the history

  2. also update frameLog

    @metagn
    metagn authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    b70974d View commit details
    Browse the repository at this point in the history