-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins test + Python3 and 1D Profile Fixes #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASvyatkovskiy
changed the title
Jenkins test + Python3 Fixes
Jenkins test + Python3 and 1D Profile Fixes
Dec 27, 2017
Will merge for now, some D3D features might need to be reviewed in a separate pull request |
jnkh
reviewed
Jan 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides full build integration for Python 2.7 and Python 3.6 with Jenkins + additional classes for running Jenkins tests in parallel (for future use).
Bug fixes for Python 3.6: tab-space inconsistencies, slicing errors due to float indexes.
In addition, it changes hashing function from default python
hash
to stablehashlib
'smd5
for reproducibility between Python 2 and Python 3. No need to setPYTHONHASHSEED
withhashlib.md5
Fix interpolation error in
edens_profile
1D profile signal (D3D, ZIPFIT01/PROFILES.EDENSFIT):