Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Re-write string docs #3281

Merged
merged 2 commits into from
Aug 8, 2023
Merged

docs: Re-write string docs #3281

merged 2 commits into from
Aug 8, 2023

Conversation

max-sixty
Copy link
Member

I'm not sure we actually should have done the r strings — we're compiling for another language, not the final result, so \t\t would have been pretty reasonable to keep as \t\t rather than two tab characters.

I'm not in a rush to revert though — folks can always just use the r-strings to get the same thing.

I'm not sure we actually should have done the `r` strings — we're compiling for another language, not the final result, so `\t\t` would have been pretty reasonable to keep as `\t\t` rather than two tab characters.

I'm not in a rush to revert though — folks can always just use the r-strings to get the same thing.
@max-sixty
Copy link
Member Author

Closes #2989

@max-sixty max-sixty merged commit f6c4096 into PRQL:main Aug 8, 2023
33 checks passed
@max-sixty max-sixty deleted the literal-docs branch August 8, 2023 07:16
@prql-bot
Copy link
Collaborator

prql-bot commented Aug 8, 2023

The backport to web failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-web web
# Navigate to the new working tree
cd .worktrees/backport-web
# Create a new branch
git switch --create backport-3281-to-web
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f6c4096428b4a427d234574d5212d77a6ae2c123
# Push it to GitHub
git push --set-upstream origin backport-3281-to-web
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-web

Then, create a pull request where the base branch is web and the compare/head branch is backport-3281-to-web.

max-sixty added a commit to max-sixty/prql that referenced this pull request Aug 8, 2023
max-sixty added a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants