build: Add Zig minimal example #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Could we add a small test? Otherwise it's likely to decay. (an alternative would be posting it to a gist / a blog, if you prefer to just publish some code quickly) |
|
I have now added a unit test. |
|
Yes I also mean to run the test in CI... I think that could be as small as just adding a job to https://github.com/PRQL/prql/blob/f9a983d1bc0d139b94246aa240d2c59edc35d709/.github/workflows/test-lib.yaml, which is easier that making a new workflow... |
max-sixty
reviewed
Aug 22, 2023
|
Looks great, thanks @vanillajonathan ! |
auto-merge was automatically disabled
August 22, 2023 22:37
Head branch was pushed to by a user without write access
|
Thanks @vanillajonathan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Zig example which uses the
libprql_lib.hC header file and loads the PRQL library using dynamic linking.