Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add hex escape #3568

Merged
merged 4 commits into from
Sep 24, 2023
Merged

feat: Add hex escape #3568

merged 4 commits into from
Sep 24, 2023

Conversation

vanillajonathan
Copy link
Collaborator

Add hex escape inside strings such as "Hello \x61".

@max-sixty
Copy link
Member

Great to see you're working on the rust code @vanillajonathan ! Nice work.

Could we add a test for this? You can copy one from just below here:

assert_snapshot!(quoted_string(false).parse(r#"'aoeu'"#).unwrap(), @"aoeu");
. Lmk if you need any guidance...

@vanillajonathan
Copy link
Collaborator Author

Thanks!

I have added a test now.

@max-sixty
Copy link
Member

Excellent! Congrats on a nice rust PR...

@max-sixty max-sixty merged commit 971d025 into PRQL:main Sep 24, 2023
33 checks passed
@vanillajonathan vanillajonathan deleted the patch-2 branch September 24, 2023 19:52
@vanillajonathan
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants