-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(book): documentation for window rows vs range #3634
Conversation
Thanks for the contribution! |
Yes code block is evaluable. I decided to not eval it because generated SQL doesn't really gives any more clarity over rows-vs-range, and due the to amount of lines it could possibly add more confusion, but I am fine either way. |
Yes, I understand the intent. |
Ideally would be to have a spoiler button that shows SQL if desired. Anyway, I just pasted output from playground and formatted the same way as other tables are formatted in the book. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is excellent! Thank you @jangorecki
FWIW I agree with @eitsupi that having the SQL there is useful. While it's a bit noisy in this case, since most of the documentation is about the behavior rather the translation, it limits how confused someone can get :)
Re having the results of queries in the book — #1895 |
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: eitsupi <ts1s1andn@gmail.com> (cherry picked from commit f2cd306)
This is great! Thank you @jangorecki . |
sort
insidewindow
Possibly it is overly verbose, but it is better like that, so there is no space for misinterpretation.