fix: darwin linking undefined reference

[pdelewski]

Linking fails on darwin due to undefined references

ld: Undefined symbols:
  _CFRelease, referenced from:
      iana_time_zone::platform::get_timezone_inner::h7a8f0a0ab162d89a in libprqlc_c.a[106](iana_time_zone-ee5bd39b68211751.iana_time_zone.9869ef72d5904e9b-cgu.0.rcgu.o)
      iana_time_zone::platform::get_timezone_inner::h7a8f0a0ab162d89a in libprqlc_c.a[106](iana_time_zone-ee5bd39b68211751.iana_time_zone.9869ef72d5904e9b-cgu.0.rcgu.o)
      iana_time_zone::platform::get_timezone_inner::h7a8f0a0ab162d89a in libprqlc_c.a[106](iana_time_zone-ee5bd39b68211751.iana_time_zone.9869ef72d5904e9b-cgu.0.rcgu.o)
      _$LT$iana_time_zone..platform..system_time_zone..SystemTimeZone$u20$as$u20$core..ops..drop..Drop$GT$::drop::hd8c2e5ebcdd4805e in libprqlc_c.a[106](iana_time_zone-ee5bd39b68211751.iana_time_zone.9869ef72d5904e9b-cgu.0.rcgu.o)
  _CFStringGetBytes, referenced from:
      iana_time_zone::platform::get_timezone_inner::h7a8f0a0ab162d89a in libprqlc_c.a[106](iana_time_zone-ee5bd39b68211751.iana_time_zone.9869ef72d5904e9b-cgu.0.rcgu.o)
  _CFStringGetCStringPtr, referenced from:
      iana_time_zone::platform::get_timezone_inner::h7a8f0a0ab162d89a in libprqlc_c.a[106](iana_time_zone-ee5bd39b68211751.iana_time_zone.9869ef72d5904e9b-cgu.0.rcgu.o)
  _CFStringGetLength, referenced from:
      iana_time_zone::platform::get_timezone_inner::h7a8f0a0ab162d89a in libprqlc_c.a[106](iana_time_zone-ee5bd39b68211751.iana_time_zone.9869ef72d5904e9b-cgu.0.rcgu.o)
  _CFTimeZoneCopySystem, referenced from:
      iana_time_zone::platform::get_timezone_inner::h7a8f0a0ab162d89a in libprqlc_c.a[106](iana_time_zone-ee5bd39b68211751.iana_time_zone.9869ef72d5904e9b-cgu.0.rcgu.o)
  _CFTimeZoneGetName, referenced from:
      iana_time_zone::platform::get_timezone_inner::h7a8f0a0ab162d89a in libprqlc_c.a[106](iana_time_zone-ee5bd39b68211751.iana_time_zone.9869ef72d5904e9b-cgu.0.rcgu.o)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [build] Error 1

[eitsupi]

Thanks, some minor comments.

[max-sixty]

Thanks @pdelewski !

(tbh I don't know this well, I will merge given @eitsupi has reviewed; @eitsupi hope that's OK)

[eitsupi]

I was just pointing out a simple formatting issue, not sure about the validity of any other changes.

In particular, the fact that the GNU Make extension was brought in here could be a very significant change, I think.

[max-sixty]

OK. I don't think the original version was written with much confidence. So I generally think it's reasonable to merge and folks can raise objections if something becomes worse...

(but open-minded ofc)

[pdelewski]

@eitsupi What GNU Make extension do you mind?

[eitsupi]

I personally don't use this file so it doesn't bother me, but I thought the person who created it might have. If not, I think it's fine.