-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Output detailed lineage graph #4533
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e3cef91
Add lineage debug command
kgutwin 740279a
Add test
kgutwin d87fdde
Nodes as a sorted vec
kgutwin 44ce19e
finalize missing TransformKinds
kgutwin 25e751d
Merge branch 'main' into kg/enhanced-lineage
kgutwin 245f10e
update tests
kgutwin 0844485
Merge branch 'main' into kg/enhanced-lineage
kgutwin ec35bf6
clippy fixes
kgutwin 8173fa5
reformat
kgutwin aa6c93e
More documentation
kgutwin 7f482a9
Add python binding (in debug submodule)
kgutwin 76cfe7f
Update tests and CLI
kgutwin 4bb3905
pre-commit updates
kgutwin 96e8a03
clippy update
kgutwin 7ead58f
Merge branch 'main' into kg/enhanced-lineage
kgutwin ed60c75
test debug::pl_to_lineage
kgutwin 1710c1a
fix a couple of panics
kgutwin c17f26b
add python snapshot tests and init comment
kgutwin 4b59743
cargo fmt
kgutwin 7ac79ee
update changelog
kgutwin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# ruff: noqa: F403, F405 | ||
# | ||
# This is the default module init provided automatically by Maturin. | ||
from .prqlc import * | ||
|
||
__doc__ = prqlc.__doc__ | ||
if hasattr(prqlc, "__all__"): | ||
__all__ = prqlc.__all__ | ||
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
def prql_lineage(prql_query: str) -> str: ... | ||
def pl_to_lineage(pl_json: str) -> str: ... |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(FYI this file seems a bit inelegant, but am guessing as a result of the python bindings. We could add a TODO to clean up if we're not confident we need this indirection)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I added the
debug
submodule to the python bindings, I needed to update the type declarations as well... which led me towards needing to use Maturin's mixed Rust/Python project layout. I then just copied Maturin's default__init__.py
(that they provide when you have a pure Rust project) into that directory.I am sure we could be more precise about the module init here, but given that it was working fine before (plus the type stubs are there, which are more descriptive anyway) I decided this was good for now. The TODO makes sense especially if more Python-native code will be added later.