Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resolver): do not copy sort when flattening a join or append transform #5066

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(resolver): do not copy sort when flattening a join or append transform #5066

wants to merge 4 commits into from
+108 −1

Conversation

lukapeschke
Copy link

closes #4063 #4947

@lukapeschke lukapeschke mentioned this pull request Dec 20, 2024
Open
2 tasks
@max-sixty
Copy link
Member

Hi @lukapeschke and thanks a lot for the contribution!

I think this is correct. Paging @aljazerzen in case he knows of any corner cases this doesn't account for.

Would you like to add to the changelog with attribution?

lukapeschke and others added 2 commits December 21, 2024 12:34
@lukapeschke
docs: update changelog
451ad58 
Signed-off-by: Luka Peschke <mail@lukapeschke.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
fd41d47 
for more information, see https://pre-commit.ci
@lukapeschke
Copy link
Author

Thanks for the quick response @max-sixty ! I updated the changelog in 451ad58 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty Awaiting requested review from max-sixty

@aljazerzen aljazerzen Awaiting requested review from aljazerzen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler panic with sort in inline join relation
2 participants
@lukapeschke @max-sixty