Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Seems the planet search endpoint is not providing distances back #19

Closed
baxterchippy opened this issue Nov 14, 2023 · 1 comment · Fixed by #20
Closed

[BUG] Seems the planet search endpoint is not providing distances back #19

baxterchippy opened this issue Nov 14, 2023 · 1 comment · Fixed by #20
Assignees
@jplacht
Labels
bug Something isn't working

Comments

@baxterchippy
Copy link

Description

When I call the planet.search() method it doesnt return distances.

Reproduction

locDistance = fio.Planet.search(include_rocky=True, distance_checks=["ANT", "MOR"])


Expected distances from the planets
@baxterchippy baxterchippy added the triage Needs investigation label Nov 14, 2023
@jplacht
Copy link
Collaborator

jplacht commented Nov 14, 2023

Additionally by info from Saganaki: Planet Search allows for up to 10 instead of 3 distances to check.

@jplacht jplacht added bug Something isn't working and removed triage Needs investigation labels Nov 14, 2023
jplacht added a commit that referenced this issue Nov 14, 2023
@jplacht
fix #19 distance results on planet search
ab49aa7
@jplacht jplacht mentioned this issue Nov 14, 2023
Merged
jplacht added a commit that referenced this issue Nov 14, 2023
@jplacht
Merge pull request #20 from jplacht/fix-planet-distances
602d1a9 
fix #19 distance results on planet search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jplacht jplacht

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #19 distance results on planet search PRUNplanner/fio_wrapper
2 participants
@jplacht @baxterchippy