Add form read/write API #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radazzouz
approved these changes
Aug 2, 2018
tomassurin
approved these changes
Aug 6, 2018
samples/Catalog/Catalog.android.js
Outdated
| { | ||
| name: "Programmatic Form Filling", | ||
| description: | ||
| "Shows how to programatically read and write PDF forms.", |
There was a problem hiding this comment.
Shows how to programatically read and write PDF forms
The "write" part implies that forms are being created to me. Can we change this to mention this is about filling forms and reading filled values.
Also "programatically" should be "programmatically" (double 'm').
index.js
Outdated
| * | ||
| * @platform android | ||
| */ | ||
| setFormFieldValue = function (value, fullyQualifiedName) { |
There was a problem hiding this comment.
Order of parameters: why is the value parameter specified before target field fqn param? Is this a JS convention?
| } else if (formElement instanceof ChoiceFormElement) { | ||
| ChoiceFormElement choiceFormElement = (ChoiceFormElement) formElement; | ||
| try { | ||
| int selectedIndex = Integer.parseInt(value); |
There was a problem hiding this comment.
What about multi-selectable choice fields?
added 2 commits
August 7, 2018 10:41
Change order of setFormFieldValue parameters
irgendeinich
force-pushed
the
reinhard/forms-api
branch
from
c9fc73b to
be45f79
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the android counter part to #106