Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github issue and pull request templates #202

Merged
merged 4 commits into from
Apr 2, 2019
Merged

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Apr 2, 2019

Details

This PR added issue and PR templates. Once merged, newly created issues and pull requests will have the "Details" and the "Acceptance Criteria" sections.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

Copy link
Contributor

@irgendeinich irgendeinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radazzouz radazzouz merged commit be86e31 into master Apr 2, 2019
@radazzouz radazzouz deleted the github-templates branch April 2, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants