Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set toolbar promise. #208

Merged
merged 3 commits into from
Apr 8, 2019
Merged

Fix set toolbar promise. #208

merged 3 commits into from
Apr 8, 2019

Conversation

nickwinder
Copy link
Contributor

@nickwinder nickwinder commented Apr 5, 2019 •
edited
Loading

Fixes https://github.com/PSPDFKit/react-native/issues/207

Details

Mistakenly did not handle the promise for set toolbar and therefore it was never fired. Same is true for the error.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@nickwinder nickwinder self-assigned this Apr 5, 2019
@nickwinder nickwinder requested a review from phraemer April 5, 2019 16:37
@nickwinder nickwinder merged commit 6215cea into master Apr 8, 2019
@nickwinder nickwinder deleted the nick/uwp/fix-set-toolbar-promise branch April 8, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phraemer phraemer phraemer approved these changes

Assignees

@nickwinder nickwinder

Labels
READY TO REVIEW windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickwinder @phraemer