Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for PSPDFKit 8.3 for iOS #210

Merged
merged 5 commits into from
Apr 23, 2019
Merged

Update for PSPDFKit 8.3 for iOS #210

merged 5 commits into from
Apr 23, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Apr 16, 2019 •
edited
Loading

Details

⚠️ Merge after PSPDFKit 8.3.0 stable is out ⚠️

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz self-assigned this Apr 16, 2019
@radazzouz radazzouz force-pushed the rad/update-for-PSPDFKit-8.3-ios branch from 43ac125 to dc2294e Compare April 17, 2019 13:15
steipete
steipete approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@steipete steipete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Maybe we can optimize that a bit more.

@radazzouz radazzouz merged commit 12fd061 into master Apr 23, 2019
@radazzouz radazzouz deleted the rad/update-for-PSPDFKit-8.3-ios branch April 23, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steipete steipete steipete approved these changes

Assignees

@radazzouz radazzouz

Labels
iOS READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radazzouz @steipete