Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement Css Customization #221

Merged
merged 6 commits into from
May 7, 2019

Conversation

nickwinder
Copy link
Contributor

@nickwinder nickwinder commented May 2, 2019

Fixes : https://github.com/PSPDFKit/react-native/issues/219

Details

As explained in https://github.com/PSPDFKit/react-native/issues/219#issuecomment-488771585 due to limitations with file permissions in UWP it was necessary to rework the CSS customization. Therefore now the viable solution is to provide a native option.

In this PR I have reverted the previous CSS work and added the option to start the PSPDFKit react native package with a Uri parameter which will be passed as the CSS resource. Within this CSS resource, it's possible to set the main colors of the toolbar. As before.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).
  • After merge ensure all links in README works.

@nickwinder nickwinder self-assigned this May 2, 2019
@nickwinder nickwinder requested a review from phraemer May 2, 2019 19:49
@nickwinder nickwinder merged commit b2b0e17 into master May 7, 2019
@nickwinder nickwinder deleted the nick/uwp/reimplement-css-customization branch May 7, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom CSS colors crash in production
2 participants