Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wrapper to PSPSDFKit for Windows 2.0 #223

Merged
merged 2 commits into from
May 21, 2019
Merged

Update wrapper to PSPSDFKit for Windows 2.0 #223

merged 2 commits into from
May 21, 2019

Conversation

nickwinder
Copy link
Contributor

@nickwinder nickwinder commented May 21, 2019 •
edited
Loading

Update wrapper to PSPSDFKit for Windows 2.0

Details

  • Update references
  • Make JsonUtils compatible.
  • update all nuget versions.
  • removed alert from library search example as this is more than fast enough now.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@nickwinder nickwinder self-assigned this May 21, 2019
@nickwinder nickwinder requested a review from phraemer May 21, 2019 15:44
steipete
steipete approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@steipete steipete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, simple enough change

@nickwinder nickwinder force-pushed the nick/uwp/update-2.0 branch from c6a15eb to 39343b2 Compare May 21, 2019 20:06
@nickwinder nickwinder merged commit 7ca8638 into master May 21, 2019
@nickwinder nickwinder deleted the nick/uwp/update-2.0 branch May 21, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steipete steipete steipete approved these changes

@phraemer phraemer Awaiting requested review from phraemer

Assignees

@nickwinder nickwinder

Labels
windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickwinder @steipete