Update Integration Steps to use CocoaPods by default starting with React Native 0.60.x #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radazzouz
force-pushed
the
rad/cocoapods-integration
branch
from
be0cbcc to
ff99a96
Compare
steipete
approved these changes
Jul 16, 2019
nickwinder
approved these changes
Jul 16, 2019
radazzouz
force-pushed
the
rad/cocoapods-integration
branch
from
bde6745 to
9574e03
Compare
irgendeinich
approved these changes
Jul 17, 2019
| - PSPDFKit 8.4.0 for iOS or later | ||
| - react-native >= 0.59.9 | ||
| - PSPDFKit 8.4.2 for iOS or later | ||
| - react-native >= 0.60.3 |
There was a problem hiding this comment.
So we don't support 0.59.9 at all anymore? We should rather write down all supported versions and mention these steps are for setting it up with 0.60.3
There was a problem hiding this comment.
I think the README should have the instructions for the latest version of React Native, as most people, when they try out our wrapper, will create a new app, and they'll be using the latest version of React Native.
If someone needs to use 0.59.9, we could always access the old instructions in the git history.
steviki
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
React Native 0.60 uses CocoaPods by default. This PR updates the main integration steps to use CocoaPods and to no longer use the manual integration. This PR also removes the old optional CocoaPods integration and the screenshots that are no longer needed.
How to Test
Follow the new integration steps. For step 4, use
yarn add https://github.com/PSPDFKit/react-native.git#rad/cocoapods-integrationinstead ofyarn add github:PSPDFKit/react-native.Acceptance Criteria
package.json,package-lock.json, andsamples/Catalog/package.json(see example commit: 1bf805f).