Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash that would occur when adding an invalid Instant JSON payload #284

Merged
merged 2 commits into from
Aug 28, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Aug 28, 2019

Fix #278


Details

The crashed occurred because we were adding a null annotation to the annotations array. We now fail gracefully and we pass the error over the bridge.

Screen Shot 2019-08-28 at 11 06 36 AM

Acceptance Criteria

  • Fix the crash.
  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense! 🙂

@radazzouz radazzouz merged commit 40b46cb into master Aug 28, 2019
@radazzouz radazzouz deleted the rad/fix-invalid-instant-json-payload-crash branch August 28, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IOS] Calling addAnnotation may still crash the whole app
2 participants