Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment to explain why we dismiss he PSPDFViewController #287

Merged
merged 2 commits into from
Aug 31, 2019
Merged

Add comment to explain why we dismiss he PSPDFViewController #287

merged 2 commits into from
Aug 31, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Aug 30, 2019 •
edited
Loading

Details

This is a followup PR for #280. See #280 (comment)

Acceptance Criteria

  • Add comment.
  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz added the iOS label Aug 30, 2019
@radazzouz radazzouz self-assigned this Aug 30, 2019
@radazzouz radazzouz requested a review from steipete August 30, 2019 16:04
@radazzouz radazzouz mentioned this pull request Aug 30, 2019
Merged
3 tasks
@radazzouz radazzouz merged commit b711d29 into master Aug 31, 2019
@radazzouz radazzouz deleted the rad/add-comment-removeFromSuperview branch August 31, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steipete steipete Awaiting requested review from steipete

Assignees

@radazzouz radazzouz

Labels
iOS READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@radazzouz