Make PdfView use PdfUiFragment instead of PdfFragment #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomassurin
approved these changes
Nov 20, 2019
| pdfFragment.addOnAnnotationEditingModeChangeListener(pdfViewModeController); | ||
| pdfFragment.addOnFormElementEditingModeChangeListener(pdfViewModeController); | ||
| // To prevent listeners from being attached multiple times we clean them before attaching them. | ||
| pdfFragment.removeOnTextSelectionModeChangeListener(pdfViewModeController); |
There was a problem hiding this comment.
Isn't this already guarded by the ListenerCollection?
skoric
approved these changes
Dec 12, 2019
added 4 commits
December 18, 2019 11:32
# Conflicts: # android/build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Hold until 6.1.0 is shipped as this is using unreleased APIs.
Resolves #245
This makes the
PdfViewuse ourPdfUiFragmentinstead of thePdfFragment. This means the we now provide the fullPdfActivityexperience when using thePSPDFKitViewon Android, matching what iOS does.If you want to continue to use the
PSPDFKitViewwithout a toolbar usinguserInterfaceViewMode: alwaysHiddenin the configuration will hide the toolbar.This should work without any additional changes in most apps. The only exception being apps that require multiple
PSPDFKitViewin the view hierarchy at the same time, this is no longer supported due to only onePdfUiFragmentbeing allowed to exist per Activity. If this is a use case you need please ping us here and let us know. This way we know if there is a need to address this.Acceptance Criteria
package.json,package-lock.json, andsamples/Catalog/package.json(see example commit: 1bf805f).