Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds instructions for how to use the Experimental Mac Catalyst Support #343

Merged
merged 9 commits into from
Jan 28, 2020

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Jan 27, 2020

Part of #332.


Details

This PR adds instructions for how to use the Experimental Mac Catalyst Support.

recording

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz force-pushed the rad/experimental-mac-catalyst-support branch from 369fe03 to 44f448f Compare January 27, 2020 20:34
@radazzouz radazzouz force-pushed the rad/experimental-mac-catalyst-support branch from 44f448f to 31cdb01 Compare January 27, 2020 20:36
@radazzouz radazzouz changed the title [WIP] Adds instructions for how to use the Experimental Mac Catalyst Support Adds instructions for how to use the Experimental Mac Catalyst Support Jan 27, 2020
@radazzouz radazzouz requested review from steviki and steipete January 27, 2020 21:10
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ios/Experimental_Mac_Catalyst_Support.md Outdated Show resolved Hide resolved
ios/Experimental_Mac_Catalyst_Support.md Outdated Show resolved Hide resolved
radazzouz and others added 2 commits January 28, 2020 10:36
Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
@radazzouz radazzouz merged commit 8609d16 into master Jan 28, 2020
@radazzouz radazzouz deleted the rad/experimental-mac-catalyst-support branch January 28, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants