Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two navigation buttons being shown while the search is open #347

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

irgendeinich
Copy link
Contributor

Details

When using showNavigationButton and opening the inline search two navigation buttons would be shown this makes sure that only one will appear at all times.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@irgendeinich irgendeinich merged commit 59916f7 into master Feb 12, 2020
@irgendeinich irgendeinich deleted the reinhard/duplicated-back-button branch February 12, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants