Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention the annotation processing API in the README #351

Merged
merged 4 commits into from
Feb 19, 2020
Merged

Mention the annotation processing API in the README #351

merged 4 commits into from
Feb 19, 2020

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Feb 19, 2020 •
edited
Loading

Details

This is a followup PR for #350 which mentions the newly added annotation processing API in the README.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz requested a review from steipete February 19, 2020 14:28
steipete
steipete approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@steipete steipete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@radazzouz radazzouz merged commit 0e4af0f into master Feb 19, 2020
@radazzouz radazzouz deleted the rad/update-readme branch February 19, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steipete steipete steipete approved these changes

Assignees
No one assigned
Labels
enhancement iOS READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radazzouz @steipete