Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put PSPDFKit on Gradle's 'api' configuration #355

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

davidschreiber
Copy link
Contributor

This allows users to use PSPDFKit classes in their app's native extension sources as it was possible when we still used the compile configuration.

Details

With our update to PSPDFKit 6.1.1 we changed the source configuration used for PSPDFKit from compile (which is deprecated) to implementation. This had the side-effect that PSPDFKit Java classes would no longer be available in apps that used native Java code. Putting the dependency on the api configuration fixes this issue.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

This allows users to use PSPDFKit classes in their app's native extension sources as it was possible when we still used the compile configuration.
@davidschreiber davidschreiber merged commit 7e3c9d5 into master Mar 10, 2020
@davidschreiber davidschreiber deleted the davidschreiber/transitive-api-dependency branch March 10, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants