Put PSPDFKit on Gradle's 'api' configuration #355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to use PSPDFKit classes in their app's native extension sources as it was possible when we still used the compile configuration.
Details
With our update to PSPDFKit 6.1.1 we changed the source configuration used for PSPDFKit from
compile
(which is deprecated) toimplementation
. This had the side-effect that PSPDFKit Java classes would no longer be available in apps that used native Java code. Putting the dependency on theapi
configuration fixes this issue.Acceptance Criteria
package.json
,package-lock.json
,samples/Catalog/package.json
, andsamples/NativeCatalog/package.json
(see example commit: 1bf805f).