Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copyright year to 2021 #386

Merged
merged 5 commits into from
Jan 11, 2021
Merged

Update copyright year to 2021 #386

merged 5 commits into from
Jan 11, 2021

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Jan 5, 2021 •
edited
Loading

Details

Update copyright year to 2021

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz requested a review from irgendeinich January 5, 2021 22:35
@radazzouz radazzouz force-pushed the rad/update-copyright-year branch from 3256b62 to 98595f5 Compare January 5, 2021 23:39
@radazzouz radazzouz force-pushed the rad/update-copyright-year branch from 98595f5 to 6a71db9 Compare January 5, 2021 23:42
@nishantdesai nishantdesai self-requested a review January 6, 2021 14:50
nishantdesai
nishantdesai approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@nishantdesai nishantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for updating!

@radazzouz radazzouz merged commit 6c1fb4e into master Jan 11, 2021
@radazzouz radazzouz deleted the rad/update-copyright-year branch January 11, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishantdesai nishantdesai nishantdesai approved these changes

@irgendeinich irgendeinich irgendeinich approved these changes

Assignees
No one assigned
Labels
Android enhancement iOS READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radazzouz @irgendeinich @nishantdesai