Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the Reader View button item on iOS #391

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Expose the Reader View button item on iOS #391

merged 2 commits into from
Mar 9, 2021

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Mar 8, 2021 •
edited
Loading

Details

Kapture 2021-03-08 at 07 35 39

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: ae02732).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz requested a review from aksh1t March 8, 2021 12:36
@radazzouz radazzouz self-assigned this Mar 8, 2021
@aksh1t
Copy link

aksh1t commented Mar 9, 2021

Hmm... somehow I'm not able to give an approved review for this, getting a GitHub error.

aksh1t
aksh1t approved these changes Mar 9, 2021
View reviewed changes
Copy link

@aksh1t aksh1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aksh1t
Copy link

aksh1t commented Mar 9, 2021

Ok, worked now! Thanks for adding the gif!

@radazzouz radazzouz merged commit 272be92 into master Mar 9, 2021
@radazzouz radazzouz deleted the rad/readerViewButtonItem branch March 9, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aksh1t aksh1t aksh1t approved these changes

Assignees

@radazzouz radazzouz

Labels
iOS READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radazzouz @aksh1t