Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PSPDFKit 7 for Android #412

Merged
merged 6 commits into from
Jul 23, 2021
Merged

Upgrade to PSPDFKit 7 for Android #412

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f84e1d2
Change PSPDFKIT_VERSION to Android 7
simoarpe Jul 21, 2021
55ed345
Update build.gradle
simoarpe Jul 23, 2021
f6ac5d8
Update build.gradle
simoarpe Jul 23, 2021
7df0904
Update build.gradle
simoarpe Jul 23, 2021
57b7c79
Update the run command for the iOS Catalog
Jul 23, 2021
1d96cef
Bump version number to 1.32.0
Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* Contains gradle configuration constants
*/
ext {
PSPDFKIT_VERSION = '6.6.2'
PSPDFKIT_VERSION = '7.0.0'
}

buildscript {
Expand All @@ -41,7 +41,7 @@ android {
buildToolsVersion "28.0.3"

defaultConfig {
minSdkVersion 19
minSdkVersion 21
targetSdkVersion 26
versionCode 1
versionName "1.0"
Expand Down
2 changes: 1 addition & 1 deletion samples/Catalog/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ The project contains a large set of sample code, which illustrates how to set up
6. Step into the Catalog project's directory: `cd /samples/Catalog`
7. Install dependencies: `yarn install` in `samples/Catalog` directory. (Because of a [bug](https://github.com/yarnpkg/yarn/issues/2165) you may need to clean `yarn`'s cache with `yarn cache clean` before.)
8. Start the Metro bundler by running `react-native start`
9. Run the app with `react-native-cli`: `react-native run-ios`
9. Run the app with `react-native-cli`: `react-native run-ios --simulator="iPad Pro (12.9-inch) (5th generation)"`

### Troubleshooting

Expand Down
4 changes: 2 additions & 2 deletions samples/Catalog/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ android {
defaultConfig {
applicationId "com.pspdfkit.react.catalog"
multiDexEnabled true
minSdkVersion 19
minSdkVersion 21
targetSdkVersion 26
versionCode 1
versionName "1.0"
Expand Down Expand Up @@ -233,4 +233,4 @@ tasks.whenTaskAdded { task ->
}
}

apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project)
apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project)
2 changes: 1 addition & 1 deletion samples/NativeCatalog/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
buildscript {
ext {
buildToolsVersion = "28.0.3"
minSdkVersion = 19
minSdkVersion = 21
compileSdkVersion = 28
targetSdkVersion = 28
}
Expand Down