Add catalog example for changing pages #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irgendeinich
approved these changes
Jul 24, 2018
index.js
Outdated
| @@ -188,7 +188,6 @@ PSPDFKitView.propTypes = { | |||
| * fragmentTag: A tag used to identify a single PdfFragment in the view hierarchy. | |||
| * This needs to be unique in the view hierarchy. | |||
| * | |||
| * @platform android | |||
There was a problem hiding this comment.
I think you accidentally removed this from the wrong doc. Should be removed from onStateChanged.
There was a problem hiding this comment.
Indeed! Nice Catch! Fixed.
radazzouz
force-pushed
the
rad/add-catalog-example-for-changing-pages
branch
from
6c3aebd to
7c5db10
Compare
steviki
approved these changes
Jul 25, 2018
samples/Catalog/Catalog.ios.js
Outdated
| configuration: { | ||
| useParentNavigationBar: true, | ||
| }, | ||
| style: { flex: 1 }, |
There was a problem hiding this comment.
I think you don't need to pass any props here, since we are not directly using a PSPDFKitView.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iOS implementation for #87