Skip to content
This repository has been archived by the owner on Aug 27, 2021. It is now read-only.

Fix for all day_event #82

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Fix for all day_event #82

merged 2 commits into from
Sep 1, 2020

Conversation

PTST
Copy link
Owner

@PTST PTST commented Sep 1, 2020

fixes #53

Repository owner deleted a comment from sourcery-ai bot Sep 1, 2020
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 1, 2020

Sourcery Code Quality Report (beta)

❌  Merging this PR will decrease code quality in the affected files by 0.06 out of 10.

Quality metrics Before After Change
Complexity 1.97 2.11 0.14 🔴
Method Length 54.19 56.62 2.43 🔴
Quality 8.62 8.56 -0.06 🔴
Other metrics Before After Change
Lines 445 459 14
Changed files Quality Before Quality After Quality Change
custom_components/o365/calendar.py 8.68 8.60 -0.08 🔴
custom_components/o365/sensor.py 8.49 8.48 -0.01 🔴

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation
custom_components/o365/sensor.py O365QuerySensor.__init__ 28 308.71 2.90 Split out functionality
custom_components/o365/sensor.py O365InboxSensor.__init__ 12 140.90 5.79 Split out functionality
custom_components/o365/calendar.py setup_platform 8 159.87 5.89 Split out functionality
custom_components/o365/calendar.py O365CalendarData.async_update 5 154.83 6.25 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@PTST
Copy link
Owner Author

PTST commented Sep 1, 2020

Partial fix for #61

@PTST PTST merged commit 497d912 into master Sep 1, 2020
@PTST PTST deleted the all_day_fix branch September 1, 2020 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All-day calendar events are not identified as "all day"
1 participant