-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename fields in tecs_status and make it EAS explicit #11944
Conversation
- msg: rename fields in tecs_status to match the variable names in TECS - adapt mavlink and vtol_att_control for new tecs_status names - fw_pos_ctrl: rename airspeed to EAS to make it explicit - fw_pos_ctrl: add const
Can you check the CI failures? Trivial style changes. Try |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@CarlOlsson shall we take a quick pass and get this in? |
Yes we can. However, I just noticed that on our codebase we can have capital letters in topic fields, something that I wrote here was not possible. If that is the case I don't have to change so much in ECL i think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new naming might be more accurate but it needs to be explained somewhere because I don't understand it as an ignorant reader.
_parameter_handles.airspeed_min = param_find("FW_AIRSPD_MIN"); | ||
_parameter_handles.airspeed_trim = param_find("FW_AIRSPD_TRIM"); | ||
_parameter_handles.airspeed_max = param_find("FW_AIRSPD_MAX"); | ||
_parameter_handles.EAS_min = param_find("FW_AIRSPD_MIN"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's EAS
? Is it translated somewhere?
Sorry for my ignorance.
float32 altitude_state | ||
float32 altitude_rate_setpoint | ||
float32 vert_vel_state | ||
float32 tas_setpoint_adj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's tas?
closing for now |
first part of #9148 (comment)
No functional change