rcout script changes #12527
rcout script changes #12527
Conversation
Tools/px4airframes/rcout.py
Outdated
| @@ -50,14 +50,23 @@ def __init__(self, groups, board): | |||
| result += "# %s\n" % param.GetName() | |||
| result += "if param compare SYS_AUTOSTART %s\n" % id_val | |||
| result += "then\n" | |||
| result += "\tsh %s\n" % path | |||
| result += "\tsh /etc/init.d/airframes/%s\n" % path | |||
| result += "\tset SYS_AUTOSTART_VALUE %s\n" % id_val | |||
There was a problem hiding this comment.
This increases flash usage (that is why there was a cd).
Can you find a solution that does not add to to each airframe?
For example:
result += "\set F %s\n" % path
And then you can check if F is valid at the end.
Also we'll need to coordinate with #12526.
-Fixed bug : cd to /etc/init.d/airframes, but no cd after -Added error report to user if value of SYS_AUTOSTART param value is incorrect
-reduced flash usage -now supports airframe .post scripts
Tools/px4airframes/rcout.py
Outdated
| @@ -62,14 +63,28 @@ def __init__(self, groups, board, post_start=False): | |||
| result += "# %s\n" % param.GetName() | |||
| result += "if param compare SYS_AUTOSTART %s\n" % id_val | |||
| result += "then\n" | |||
| result += "\tsh %s\n" % path | |||
| if post_start: | |||
There was a problem hiding this comment.
Can you keep the logic the same for post_start? The only thing that needs to be different is not to print an error if there is no .post file.
There was a problem hiding this comment.
@bkueng
you want to keep the logic with AIRFRAME for .post files?
I did it that way so that if there's no .post file rc.autostart.post will be empty, if we'll continue the same logic the script will never be empty :
set AIRFRAME none
if [ ${AIRFRAME} != none ]
sh /etc/init.d/airframes/${AIRFRAME}
fi
unset AIRFRAME
I tried to avoid it.
There was a problem hiding this comment.
It's a small optimization, so that reasoning works too. I slightly prefer to be consistent here, but either way is fine with me.
There was a problem hiding this comment.
I agree with @bkueng, it is better to have the same logic and same output format for both files.
Flash-wise, the 5 lines you show should be OK.
Same logic for non .post files and .post files
-Fixed bug : cd to /etc/init.d/airframes, but no cd after
-Added error report to user if value of SYS_AUTOSTART param value is incorrect