Add airframe .post scripts on NuttX targets #12526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
previously approved these changes
Jul 22, 2019
There was a problem hiding this comment.
Looks good, I assume https://github.com/PX4/Firmware/blob/70023eb263d4b2381b6f653910c5fc240febb3ca/Tools/px4airframes/srcparser.py#L269 will filter the .post files, did you check that?
Merged
jlecoeur
force-pushed
the
pr-nuttx_airframe_post_script
branch
from
70023eb to
4d25776
Compare
jlecoeur
force-pushed
the
pr-nuttx_airframe_post_script
branch
from
4d25776 to
ec68b49
Compare
|
@bkueng Thanks for the review, I made the changes, can you review again?
Yes, the .post files do not need to be parsed, so this is fine like this. |
bkueng
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
On POSIX targets, it is possible to add a
.postscript that will be run at the end of the startup.See for example
ROMFS/px4fmu_common/init.d-posix/1013_iris_vision.post.On Nuttx targets, this is not supported.
Describe your preferred solution
Add support for
.postscripts on NuttX targets.Additional context
Similar to how
ROMFS/px4fmu_common/init.d/rc.autostartis generated at compile time, this PR generates a new fileROMFS/px4fmu_common/init.d/rc.autostart.postwhich is called at the end ofROMFS/px4fmu_common/init.d/rcS.Test example:
ROMFS/px4fmu_common/init.d/airframes/4001_quad_x.postmavlink stream -d /dev/ttyS1 -s DEBUG_VECT -r 24001_quad_x.postinROMFS/px4fmu_common/init.d/airframes/CMakeLists.txt@bkueng this is what we discussed on Slack. By default the new script is emtpy so it does not increase the flash usage.
@hamishwillee this should not affect the autogenerated airframe mardown file, but better double check.