-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add camera models for VTOL models for sitl #13214
Conversation
Some developers will not have the CPU performance to run this - have we tested the impact? |
@LorenzMeier I didn't add the camera to the existing vtol models, but created additional models for that reason. I will do a quick test on how much CPU load is required, but on my laptop it wasn't so bad. |
@Jaeyoung-Lim HOw are these used? Specifically, I assume these allow you to stream video and take images from gazebo. Looking at existing docs - what of the following is true?: http://dev.px4.io/master/en/simulation/gazebo.html#video-streaming |
I don't see an update of the SITL submodule - how did the new models come in? |
@LorenzMeier There was a discussion in PX4/PX4-SITL_gazebo-classic#360 where the models were considered redundant and a test regarding surveying would makes sense to get the models in |
I assume you'll answer this before you merge: #13214 (comment) IMO a feature that people can't easily discover use might as well not exist. |
@hamishwillee, @Jaeyoung-Lim and I already decided in an approach to have usage to the models being added: survey mission testing in CI. More to come next. |
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Closing as stale |
Describe problem solved by this pull request
This is a follow up of PX4/PX4-SITL_gazebo-classic#360 which adds a sitl models for VTOLS that have camera attached in order to simulate survey missions.