Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera models for VTOL models for sitl #13214

Closed
wants to merge 1 commit into from
Closed

Conversation

Jaeyoung-Lim
Copy link
Member

Describe problem solved by this pull request
This is a follow up of PX4/PX4-SITL_gazebo-classic#360 which adds a sitl models for VTOLS that have camera attached in order to simulate survey missions.

@LorenzMeier
Copy link
Member

Some developers will not have the CPU performance to run this - have we tested the impact?

@Jaeyoung-Lim
Copy link
Member Author

@LorenzMeier I didn't add the camera to the existing vtol models, but created additional models for that reason.

I will do a quick test on how much CPU load is required, but on my laptop it wasn't so bad.

@hamishwillee
Copy link
Contributor

@Jaeyoung-Lim HOw are these used? Specifically, I assume these allow you to stream video and take images from gazebo.

Looking at existing docs - what of the following is true?: http://dev.px4.io/master/en/simulation/gazebo.html#video-streaming

@LorenzMeier
Copy link
Member

I don't see an update of the SITL submodule - how did the new models come in?

@Jaeyoung-Lim
Copy link
Member Author

Jaeyoung-Lim commented Oct 28, 2019

@LorenzMeier There was a discussion in PX4/PX4-SITL_gazebo-classic#360 where the models were considered redundant and a test regarding surveying would makes sense to get the models in

@hamishwillee
Copy link
Contributor

Hi @Jaeyoung-Lim

I assume you'll answer this before you merge: #13214 (comment)

IMO a feature that people can't easily discover use might as well not exist.

@TSC21
Copy link
Member

TSC21 commented Oct 28, 2019

Hi @Jaeyoung-Lim

I assume you'll answer this before you merge: #13214 (comment)

IMO a feature that people can't easily discover use might as well not exist.

@hamishwillee, @Jaeyoung-Lim and I already decided in an approach to have usage to the models being added: survey mission testing in CI. More to come next.

@stale
Copy link

stale bot commented Jan 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@Jaeyoung-Lim
Copy link
Member Author

Closing as stale

@Jaeyoung-Lim Jaeyoung-Lim deleted the pr-cam-models branch June 14, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants