Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for vtol attitude offboard setpoints #8526

Closed
wants to merge 2 commits into from
Closed

add support for vtol attitude offboard setpoints #8526

wants to merge 2 commits into from

Conversation

Boyang--Li
Copy link

@Boyang--Li Boyang--Li commented Dec 26, 2017

The previous firmware dose not support off-board attitude control for VTOL vehicles.
We add support to this function in hover state by changing the mavlink message head.
We tested it with Gazebo simulation and indoor flight experiment, px4fmu-v2_lpe (log).

@dagar
Copy link
Member

dagar commented Dec 26, 2017

This looks okay, but I'm wondering if we should solve it slightly differently so that we don't need even more special handling if FW offboard is wanted later.

In VTOL the regular attitude controllers still subscribe to vehicle_attitude_setpoint, the virtual topics (mc_virtual_attitude_setpoint/fw_virtual_attitude_setpoint) are used by the vtol controller to intercept each position controller and facilitate transition.

If you instead blocked vehicle_attitude_setpoint publications in vtol_attitude (https://github.com/PX4/Firmware/blob/master/src/modules/vtol_att_control/vtol_att_control_main.cpp#L888) it would work for both MC and FW with no mavlink change. The only additional thing to consider is transition.

@dagar
Copy link
Member

dagar commented Dec 26, 2017

Here's the logic for publishing in the MC position controller. https://github.com/PX4/Firmware/blob/master/src/modules/mc_pos_control/mc_pos_control_main.cpp#L3180-L3200

@stale
Copy link

stale bot commented Jan 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Feb 4, 2019

Closing as stale.

@stale stale bot closed this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants