Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VTOL thrust bug on takeoff still existent #12171

Closed
MaEtUgR opened this issue Jun 4, 2019 · 0 comments · Fixed by #12250
Closed

VTOL thrust bug on takeoff still existent #12171

MaEtUgR opened this issue Jun 4, 2019 · 0 comments · Fixed by #12250
Assignees
@MaEtUgR @RomanBapst
Labels
bug Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing! priority-critical
Milestone
Release v1.9.1

Comments

@MaEtUgR
Copy link
Member

MaEtUgR commented Jun 4, 2019 •
edited by AuterionWrikeBot
Loading

Describe the bug
The issue extensively described in
#12001 (comment)
and point 5. of #12014 (comment)
is still existent on VTOLs (also in the release 1.9).

To Reproduce
Reproducable in SITL with the Deltawing

  1. Start simulation with joystick configured
  2. When GPS is locked but it's still in Manual mode from bootup hold throttle stick high and switch to position mode.
  3. Let go of the stick and let it center
  4. Arm and the vehicle goes up without smooth takeoff and possibly detects landing even though it should idle

Expected behavior
Point 4. above.

Drone (please complete the following information):

  • problem found on a real VTOL with pixhawk 4 and almost unchanged 1.9 stable flashed

Additional context
1c776f1 fixes this problem for multicopters and I did extensive testing on multicopter platforms but didn't know that VTOL seems to work differently and apparently doesn't go though this part of the code.

FYI @RomanBapst @sfuhrer
@MaEtUgR MaEtUgR self-assigned this Jun 4, 2019
@dagar dagar added the Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing! label Jun 4, 2019
@dagar dagar added this to the Release v1.9.1 milestone Jun 4, 2019
@weekly-digest weekly-digest bot mentioned this issue Jun 9, 2019
Closed
MaEtUgR added a commit that referenced this issue Jun 12, 2019
@MaEtUgR
vtol_att_control: apply multicopter takeoff hotfix also for vtol
6ee9936 
Please see reference:
#12171
@MaEtUgR MaEtUgR mentioned this issue Jun 12, 2019
Merged
@PX4 PX4 deleted a comment from AuterionWrikeBot Jun 12, 2019
dagar pushed a commit that referenced this issue Jun 12, 2019
@MaEtUgR @dagar
vtol_att_control: apply multicopter takeoff hotfix also for vtol (#12250
048cca7 
)

Please see reference:
#12171
dagar pushed a commit that referenced this issue Jun 12, 2019
@MaEtUgR @dagar
vtol_att_control: apply multicopter takeoff hotfix also for vtol (#12250
0c110a4 
)

Please see reference:
#12171
This was referenced Oct 15, 2019
Merged
Merged
@MaEtUgR MaEtUgR mentioned this issue Dec 15, 2019
Closed
dakejahl pushed a commit to InspiredMartin/Firmware that referenced this issue Jan 16, 2020
@MaEtUgR @dakejahl
vtol_att_control: apply multicopter takeoff hotfix also for vtol (PX4…
6b98433 
…#12250)

Please see reference:
PX4#12171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaEtUgR MaEtUgR

@RomanBapst RomanBapst

Labels
bug Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing! priority-critical
Projects
None yet
Milestone
Release v1.9.1
Development

Successfully merging a pull request may close this issue.

VTOL: apply multicopter takeoff hotfix also for vtol PX4/PX4-Autopilot
3 participants
@dagar @MaEtUgR @RomanBapst