Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mavlink PLAY_TUNE message does not play tune #12309

Closed
wluker opened this issue Jun 19, 2019 · 8 comments
Closed

Mavlink PLAY_TUNE message does not play tune #12309

wluker opened this issue Jun 19, 2019 · 8 comments
Labels

Comments

@wluker
Copy link

wluker commented Jun 19, 2019

Describe the bug
Sending a tune string "MFT200CDEFGAB" via a PLAY_TUNE mavlink message does not produce any sound on the drone.

From the fix for #12059 I can produce sound with "tune_control play -m "MFT200CDEFGAB" ".

The PLAY_TUNE mavlink handler is implemented in https://github.com/PX4/Firmware/blob/4831a4b0cfde499eb1a20257cc46b130e6554e3a/src/modules/mavlink/mavlink_receiver.cpp#L1627 and I am sending the correct message because this triggers, but it doesn't produce sound.

To Reproduce
Steps to reproduce the behavior:

  1. Drone switched on '...'
  2. send PLAY_TUNE mavlink message with "MFT200CDEFGAB" in PLAY_TUNE.tune
  3. Listen for sound

Expected behavior
A tune should be played.

Drone (please complete the following information):

  • Pixhawk2 with latest firmware from git
@stale
Copy link

stale bot commented Sep 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mcsauder
Copy link
Contributor

Hi @wluker , if I issue the command tune_control play -m "MFT200CDEFGAB" from the mavlink console in QGC the tune plays correctly for me on fmu-v2 and fmu-v5.

I think we can close this issue, but if I am not understanding your issue or this is still an issue for you would you please re-open? Thanks!

@wluker
Copy link
Author

wluker commented Sep 18, 2019

Hi @mcsauder

Thanks for looking into this. This issue is not in tune_control play -m "MFT200CDEFGAB" because that plays for me as well. The issue is that you can't trigger any tune via the mavlink message PLAY_TUNE. https://mavlink.io/en/messages/common.html#PLAY_TUNE

I was trying to send that message via an offboard controller, but no tones were being played even though I could tell PX4 was receiving the message. Maybe I am misunderstanding the intended use of the PLAY_TUNE message.

@stale
Copy link

stale bot commented Dec 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Dec 19, 2019
@julianoes
Copy link
Contributor

Fix coming in #13158.

@stale stale bot removed the stale label Jan 30, 2020
@stale
Copy link

stale bot commented Apr 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Apr 29, 2020
@julianoes
Copy link
Contributor

Fixed in #13158.

@mrpollo
Copy link
Contributor

mrpollo commented Apr 29, 2020

In your face @Stale bot!

Thanks @julianoes 🎵🎶🎵🎶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants