Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC override for VTOL #13061

Closed
sfuhrer opened this issue Oct 1, 2019 · 3 comments
Closed

RC override for VTOL #13061

sfuhrer opened this issue Oct 1, 2019 · 3 comments
Assignees
Labels
Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing!

Comments

@sfuhrer
Copy link
Contributor

sfuhrer commented Oct 1, 2019

Describe the bug
Since #12495 got merged 3 months ago, RC override is disabled for fixed-wing flight of a VTOL. It is though still enabled for hover flight. The current logic inside commander is such that if you move the sticks during the FW flight, and then don't move it back to where they were were originally, the RC override triggers a switch to manual (position) mode as soon as the back-transition happens. The most likely stick to cause that is the throttle stick, as it is often not spring-loaded.

I know of at least one case where the pilot moved the throttle stick during FW flight (probably to be prepared to take-over fast if necessary).

To Reproduce
In sitl VTOL:

  • plan mission with VTOL_takeoff, some FW flight and then a transition to hover
  • enable RC_override (COM_RC_OVERRIDE)
  • move the throttle stick during the FW flight and keep it constant
  • now, the RC override triggers as soon as the backtransition happens

Expected behavior
I would expect that only movements on the RC sticks during actual hover trigger the RC override.

@MaEtUgR
Copy link
Member

MaEtUgR commented Oct 6, 2019

Shit, that's a corner case I never went into while testing since I did it with a spring-loaded joystick that was always in middle position when I back transitioned.

@MaEtUgR MaEtUgR self-assigned this Oct 6, 2019
@stale stale bot added the stale label Jan 4, 2020
@sfuhrer sfuhrer removed the stale label Jan 10, 2020
@stale stale bot added the stale label Apr 9, 2020
@PX4 PX4 deleted a comment from stale bot Apr 9, 2020
@stale stale bot removed the stale label Apr 9, 2020
@PX4 PX4 deleted a comment from stale bot Apr 9, 2020
@stale stale bot added the stale label Jul 11, 2020
@PX4 PX4 deleted a comment from stale bot Aug 5, 2020
@stale stale bot removed the stale label Aug 5, 2020
@jkflying
Copy link
Contributor

jkflying commented Aug 5, 2020

Potential fix: #15495

@MaEtUgR
Copy link
Member

MaEtUgR commented Nov 19, 2020

Fixed in #15495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants