-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC override enabled by default #12495
Conversation
We discussed this yesterday in the dev call and realized there were some misunderstandings. The result was that this functionality is only useful for rotary-wing (multicopter) flying since it's a big safety hazard to accidentally bring a fixed wing out of an auto mode e.g. a mission and fly away in a straight line or into an obstacle. I will adjust the implementation accordingly. |
AAs discussed in the devcall this functionality is only useful for rotary-wing (multicopter) flying since it's a big safety hazard to accidentally bring a fixed wing out of an auto mode e.g. a mission and fly away in a straight line or into an obstacle.
It doesn't affect fixed wing flying anymore. I disabled it for the deltaquad since I presume @sanderux prefers to have the feature disabled even when flying in multicopter mode.
8c3aa65
to
84f6c3e
Compare
I SITL tested and it works like expected:
And the feature is now on by default. Can anyone review? |
|
Describe problem solved by the proposed pull request
As a follow up to #12346 I separated enabling RC override by default from the auto disarm default. To implement the suggestion from #12346 (comment) I refactored the conditions to be more readable and when I asked @RomanBapst some questions about VTOL and fixed wing and the result was that he doesn't understand why the feature should not be also useful for fixed wing use. Can we discuss that in the dev call tomorrow?
Additional context
Mildly related to #12361