Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC override enabled by default #12495

Merged
merged 3 commits into from
Jul 22, 2019
Merged

RC override enabled by default #12495

merged 3 commits into from
Jul 22, 2019

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Jul 16, 2019

Describe problem solved by the proposed pull request
As a follow up to #12346 I separated enabling RC override by default from the auto disarm default. To implement the suggestion from #12346 (comment) I refactored the conditions to be more readable and when I asked @RomanBapst some questions about VTOL and fixed wing and the result was that he doesn't understand why the feature should not be also useful for fixed wing use. Can we discuss that in the dev call tomorrow?

Additional context
Mildly related to #12361

@MaEtUgR MaEtUgR requested review from RomanBapst and sanderux July 16, 2019 15:33
@MaEtUgR MaEtUgR self-assigned this Jul 16, 2019
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Jul 18, 2019

We discussed this yesterday in the dev call and realized there were some misunderstandings. The result was that this functionality is only useful for rotary-wing (multicopter) flying since it's a big safety hazard to accidentally bring a fixed wing out of an auto mode e.g. a mission and fly away in a straight line or into an obstacle. I will adjust the implementation accordingly.

@MaEtUgR MaEtUgR changed the title RC override enabled by default [WIP] RC override enabled by default Jul 18, 2019
MaEtUgR added 3 commits July 18, 2019 14:56
AAs discussed in the devcall this functionality is only useful for
rotary-wing (multicopter) flying since it's a big safety hazard to
accidentally bring a fixed wing out of an auto mode e.g. a mission
and fly away in a straight line or into an obstacle.
It doesn't affect fixed wing flying anymore. I disabled it for the
deltaquad since I presume @sanderux prefers to have the feature disabled
even when flying in multicopter mode.
@MaEtUgR MaEtUgR force-pushed the rc-override-by-default branch from 8c3aa65 to 84f6c3e Compare July 18, 2019 13:19
@MaEtUgR MaEtUgR changed the title [WIP] RC override enabled by default RC override enabled by default Jul 19, 2019
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Jul 19, 2019

I SITL tested and it works like expected:

  • RC override works on multicopter
  • RC override works on VTOLs in multicopter mode
  • no effect on Planes or VTOLs in fixed wing mode

And the feature is now on by default. Can anyone review?

@MaEtUgR MaEtUgR merged commit e964af9 into master Jul 22, 2019
@MaEtUgR MaEtUgR deleted the rc-override-by-default branch July 22, 2019 07:57
@hamishwillee
Copy link
Contributor

hamishwillee commented Jul 23, 2019

@MaEtUgR

  1. I presume value here of "1" means "enabled"? Certainly worth clarifying that 1 means enabled. Might be worth also providing min, max, increment so that this is forced to 1 or 0.
    image

  2. So if you're in auto, land, mission, takeoff, hold, and you move the sticks, then you change to position control mode?

@MaEtUgR
Copy link
Member Author

MaEtUgR commented Jul 23, 2019

@hamishwillee

  1. The parameter is tagged with @boolean in the definition which implies it can only be enabled and disabled. JFYI the actual implementation takes all non-zero values as enabled. Could it be that the automatic parameter reference generation doesn't support the boolean tag as you expect?
  2. For multicopters and VTOLs in multicopter mode only the vehicle switches out of any auto mode (the ones you listed) into position mode if it's not in a critical battery action (because you might accidentally switch out) when you clearly move any of the main sticks (x,y,z,yaw).

@hamishwillee
Copy link
Contributor

Thanks @MaEtUgR . I've created #12546 for the rendering of booleans.

IF someone moves the sticks in hold mode (say), won't their RC control be left in an inconsistent state - where moving back to hold is messy because the switch is in hold mode position while vehicle is in position mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants