THR_MDL_FAC parameter unclear #13105
Assignees
Comments
Finwood
added a commit
to Finwood/PX4
that referenced
this issue
Oct 8, 2019
The documentation of the thrust model parameter `THR_MDL_FAC` did not mention both thrust and "PWM" being relative values. Also the use of the term PWM could be misleading, since the model is applicable to CAN ESCs as well. This commit rephrases the user documentation string and a few source code comments, but no logic changes are made. Closes PX4#13105
bkueng
pushed a commit
that referenced
this issue
Oct 9, 2019
The documentation of the thrust model parameter `THR_MDL_FAC` did not mention both thrust and "PWM" being relative values. Also the use of the term PWM could be misleading, since the model is applicable to CAN ESCs as well. This commit rephrases the user documentation string and a few source code comments, but no logic changes are made. Closes #13105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Documentation for THR_MDL_FAC is unclear.
The equation in description refers to PWM, but it is not clear this is a normalised value. It should be renamed to something like
out_normalized.From Lasse Fröhner
The question originated here: https://discuss.px4.io/t/thrust-curve-compensation-through-thr-mdl-fac/13207
The text was updated successfully, but these errors were encountered: