Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Collision avoidance library addition example #10809

Closed
wants to merge 5 commits into from

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Nov 5, 2018

@baumanta I took the time now to prepare this example for what I meant in my review here: #10785 (review)
I hope this helps you. If I didn't do any mistakes it should do the exact same thing as before but is a lot more modular.

Notes:

  • I know that I only added the CollisionAvoidance library to be used in the FlightTaskManualPosition. It's because it's currently only used there. If it will be used for other tasks as well it's easy to adjust. Just move the object to the common ancestor which may as well be the base class.
  • What I didn't change here is where the files are and the CMakeLists. I would suggest to handle it exactly like these libraries here: https://github.com/PX4/Firmware/tree/master/src/lib/FlightTasks/tasks/Utility
  • Maybe there needs to be an unpublish on flight task destruction for the publications inside the library, I didn't look into that

FYI @mrivi

@MaEtUgR
Copy link
Member Author

MaEtUgR commented Nov 7, 2018

content of this branch got cherry-picked

@MaEtUgR MaEtUgR closed this Nov 7, 2018
@MaEtUgR MaEtUgR deleted the collision_avoidance_library_example branch November 7, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants