Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/distance_sensor replace std::vector usage with px4::Array #11242

Merged
merged 3 commits into from
Jan 20, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Jan 19, 2019

@dagar dagar requested review from davids5 and dakejahl January 19, 2019 18:03
@dagar dagar changed the title Pr stdvector remove drivers/distance_sensor replace std::vector usage with px4::Array Jan 19, 2019
@dagar
Copy link
Member Author

dagar commented Jan 19, 2019

The older raspberrypi/bebop toolchain seg faults on Array if the internal data is initialized (added in c4e4bb8e9451, removed in 3184d78543169be8e).

In file included from ../../src/modules/logger/logger.h:38:0,
                 from ../../src/modules/logger/logger.cpp:35:
../../src/include/containers/Array.hpp: In constructor 'constexpr px4::Array<px4::logger::LoggerSubscription, 64u>::Array()':
../../src/include/containers/Array.hpp:42:7: internal compiler error: Segmentation fault
 class Array
       ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://bugs.launchpad.net/gcc-linaro> for instructions.
[13/298] Building CXX object src/modules/mavlink/CMakeFiles/modules__mavlink.dir/mavlink_ftp.cpp.o
ninja: build stopped: subcommand failed.
Makefile:171: recipe for target 'emlid_navio2_cross' failed
make: *** [emlid_navio2_cross] Error 1

@dagar dagar added this to the Release v1.9.0 milestone Jan 19, 2019
@dagar dagar force-pushed the pr-stdvector_remove branch from 3184d78 to c84b97a Compare January 19, 2019 20:04
@LorenzMeier LorenzMeier merged commit 652c9df into master Jan 20, 2019
@LorenzMeier LorenzMeier deleted the pr-stdvector_remove branch January 20, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove std::vector usage
2 participants