px4_fmuv4:Add Runtime SPI4 #11301
Merged
px4_fmuv4:Add Runtime SPI4 #11301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Jan 25, 2019
src/drivers/pmw3901/pmw3901.cpp
Outdated
| // #error "add the required spi dev from board_config.h here" | ||
| // #endif | ||
|
|
||
| #define PMW3901_BUS PX4_SPI_BUS_EXTERNAL |
There was a problem hiding this comment.
There was a problem hiding this comment.
@dagar - thank you the is cloned here.
davids5
force-pushed
the
master_fmuv4_runtime_spi4
branch
from
5d170c0 to
a2f5277
Compare
|
@DanielePettenuzzo @dagar - run time detections is ready to test. When a ESP2866 is plugged in it should work and have no activity on When wired as described here and 3 - GOIO2 to GND SPI4 attached devices should work. |
The build is built with SPI4. At run time the signal GPIO_8266_GPIO2 it tested. If it is low the SPI4 is configred. if it is high SPI4 is not configured. We still need a call out in the driver start to test if the bus should be used. I.E manifest.
dagar
force-pushed
the
master_fmuv4_runtime_spi4
branch
from
a2f5277 to
da8eb74
Compare
dagar
approved these changes
Jan 29, 2019
| * | ||
| ************************************************************************************/ | ||
|
|
||
| enum board_bus_types { |
There was a problem hiding this comment.
This looks good for now, but ultimately I'd like to see if we can unify this with Device (https://github.com/PX4/Firmware/blob/master/src/lib/drivers/device/Device.hpp) where we already have a notion of bus type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dagar, @DanielePettenuzzo - Ready for test.
The build is built with SPI4. At run time the signal
GPIO_8266_GPIO2 it tested. If it is low the SPI4 is configured.
if it is high SPI4 is not configured.
@dagar - The mods to use the ESP module and SPI4. I would suggest making a cable to Y VDD3v3_PERIH and GND to both devices. The key here is to isolate ESP 8266 6, 5, 4, and 3 from FMU connector.
Mods
Wire FMU connector to SPI device:
1 - SPI device GND
3 - GOIO2 to GND - Signals board to enable SPI4 on this connector.
6 - SPI device MOSI
5 - SPI device CLK
4 - SPI device MSIO
8 - SPI device VDD3V3
10 - SPI device Chip Select
On ESP 8266
3 - Leave not connected.
On the ESP 8266 Connect pins 8 to 6 and 4 together.
Wire FMU connector to ESP 8266 :
1 - ESP 8266 Pin 1 GND
2 - ESP 8266 Pin 2 TxD
7 - ESP 8266 Pin 7 RxD
8 - ESP 8266 Pin 8 VDD3V3
10 - SPI device Chip Select
You must Isolate ESP 8266 6, 5, 4 and 3, from FMU connector.