Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avionics power only circuit breaker #11538

Closed
wants to merge 4 commits into from
Closed

Conversation

simonegu
Copy link
Contributor

@simonegu simonegu commented Feb 25, 2019

Describe problem solved by the proposed pull request
The CBRK_SUPPLY_CHK circuit breaker is used to disable the preflight checks
https://github.com/PX4/Firmware/blob/103fcc6c0583645e742a1ecac1651554bc73f9c3/src/modules/commander/PreflightCheck.cpp#L706
https://github.com/PX4/Firmware/blob/103fcc6c0583645e742a1ecac1651554bc73f9c3/src/modules/commander/PreflightCheck.cpp#L936-L940
but also the low battery arming behavior.
https://github.com/PX4/Firmware/blob/103fcc6c0583645e742a1ecac1651554bc73f9c3/src/modules/commander/state_machine_helper.cpp#L909-L929

Describe your preferred solution
The new circuit breaker CBRK_AVIO_CHK disables only the avionics checks (5V and 3.3V) without impacting the arming behavior on low battery. This solution does not impact the behavior on the CBRK_SUPPLY_CHK circuit breaker.

Maybe we should separate the two functionalities, thoughts?

@simonegu simonegu requested a review from dagar February 25, 2019 14:46
@simonegu simonegu force-pushed the pr-add-avionics-power-check branch from 103fcc6 to 00bed3a Compare February 25, 2019 14:47
@dagar
Copy link
Member

dagar commented Feb 25, 2019

Additionally, wouldn't it make more sense to make the avionics power checks configurable per board? Isn't that the underlying issue here?

@dagar
Copy link
Member

dagar commented Feb 25, 2019

Personally I don't even like the circuit breakers in many cases. What about a more explicit list of preflight checks? Likely a big bitmask of options in a single parameter.

Things like low battery can already be covered by the existing battery failsafe parameters.

@simonegu
Copy link
Contributor Author

@dagar make sense. If i understood you correctly, this would then be part of the board configuration or do you think a parameter could be useful?
Do you think we should do it for all the different preflight checks?

@dagar
Copy link
Member

dagar commented Feb 26, 2019

@dagar make sense. If i understood you correctly, this would then be part of the board configuration or do you think a parameter could be useful?

Board configuration if possible, or if it's a variant of an existing board we could make the levels configurable via parameter.

Do you think we should do it for all the different preflight checks?

Yes, I want to collect them all into a bitmask parameter. From there I want to expand the checks and add more granularity. Something like COM_ARM_REQ, that will consume the current arming requirement parameters like COM_ARM_WO_GPS and COM_ARM_MIS_REQ and add all these new pieces.

@simonegu
Copy link
Contributor Author

Ok, let me close this PR then. Will try to squeeze the functionality in next week 😄

@simonegu simonegu closed this Feb 26, 2019
@simonegu simonegu deleted the pr-add-avionics-power-check branch February 26, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants