Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not check VP fusion during GPS startup #11865

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Conversation

copterspace
Copy link
Contributor

This is solution for #11864

@dagar dagar requested a review from TSC21 April 16, 2019 14:56
@dagar dagar added the [ARCHIVED] lpe (depreciated) Local position estimator label Apr 16, 2019
@PX4 PX4 deleted a comment from stale bot Jul 15, 2019
@stale stale bot removed the Admin: Wont fix label Jul 15, 2019
@julianoes julianoes requested a review from mhkabir July 15, 2019 17:42
@julianoes
Copy link
Contributor

@mhkabir or @TSC21 can you check this?

@copterspace
Copy link
Contributor Author

Dear colleagues, here's video example of my test flying mission: https://www.youtube.com/watch?v=RNG2Y_IHx6Y
Without #11865 it would not work.

@stale
Copy link

stale bot commented Oct 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Oct 14, 2019
Copy link
Member

@TSC21 TSC21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question here is: if you have GPS and vision valid, who's going to be the one initializing the global origin? GPS or Vision? Answer: I assure it will always be GPS, cause GPS is the first sensor source to be initialized in LPE. Basically you are saying that LPE will always set the global origin from the GPS data and then use vision as odometry. Generally speaking, this is fine, as GPS is a global reference frame with no drift, while vision has an arbitrary navigation frame and tends to drift.
The logic should also work if you start with vision valid and then connect valid GPS readings, where Vision had already set the global origin.
So, I am approving and merging.

@stale stale bot removed the stale label Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[ARCHIVED] lpe (depreciated) Local position estimator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants