sih: move to PX4Accelerometer/PX4Gyroscope/PX4Magnetometer/PX4Barometer helpers #12142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discovered that astyle was chocking on PRINT_MODULE_DESCRIPTION, which is how this slipped through CI. |
bkueng
reviewed
Jun 5, 2019
| struct sensor_accel_s _sensor_accel {}; | ||
| orb_advert_t _sensor_accel_pub{nullptr}; | ||
| // simulated sensor instances | ||
| PX4Accelerometer _px4_accel{ 1311244, ORB_PRIO_DEFAULT, ROTATION_NONE }; // 1311244: DRV_ACC_DEVTYPE_ACCELSIM, BUS: 1, ADDR: 1, TYPE: SIMULATION |
There was a problem hiding this comment.
Can you use a macro/method for the ID?
There was a problem hiding this comment.
We could build them up piece by piece with multiple calls setting each thing, but it didn't seem worth it given we ultimately still have magic numbers floating around.
There was a problem hiding this comment.
We could build them up piece by piece with multiple calls setting each thing
I still prefer that.
There was a problem hiding this comment.
I'll come back to it in another pass system wide.
This was referenced Jun 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@romain-chiap
The only real change to check (and test) here is
void Sih::send_IMU()that's been updated to use helper classes for publishing raw sensor data. Using these are important so that the same filtering and integration is applied to the sensor data.