Standardize land_detector module class variable naming #12339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andDetector class.
…rLandDetector class.
…MulticopterLandDetector class.
dagar
approved these changes
Jun 26, 2019
|
Thank you @dagar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
The class member variable naming in the land_detector module varies from class to class and within classes. Non-standard application of a general convention leads to code rot.
This PR standardizes class variable naming with an easily identifiable pattern that is not ambiguous and easily followed for all readers.
Only naming is changed by this PR, no logic is impacted.
Test data / coverage
Flight tests to exercise the LandDetector and MulticopterLandDetector classes on a 250 quad with pixhawk mini 4:
All tests perform identical to PX4:master and perform as expected.
Additional context
This PR streamlines remaining work for #9756 and minimizes the diff in #11857 .
@dagar , @bkueng .
Please let me know if you have any questions on this PR. Thanks!