Fix SITL segfault in camera trigger #12547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Jul 24, 2019
RomanBapst
force-pushed
the
pr-cam_trig_sitl
branch
from
23bd442 to
dabfd55
Compare
|
@bkueng I addressed your comment, please have a look. |
bkueng
reviewed
Aug 5, 2019
Signed-off-by: RomanBapst <bapstroman@gmail.com>
supported on posix Signed-off-by: RomanBapst <bapstroman@gmail.com>
RomanBapst
force-pushed
the
pr-cam_trig_sitl
branch
from
dabfd55 to
de794fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SITL the only supported camera interface mode is via mavlink. If the interface was not set to mavlink (and by default it was not set to that) then no camera interface was created and a null pointer was invoked.
This PR does the following: