Rename VT_PSHER_RMP_DT to VT_PUSHER_RMP_DT to close PR #11680 #12619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsauder
changed the title
mcsauder
changed the title
mcsauder
force-pushed
the
vt_pusher_naming
branch
from
5ce02b7 to
344b127
Compare
|
Rebased with current master. |
mcsauder
force-pushed
the
vt_pusher_naming
branch
from
344b127 to
8a4109f
Compare
mcsauder
force-pushed
the
vt_pusher_naming
branch
from
8a4109f to
35ae15f
Compare
mcsauder
force-pushed
the
vt_pusher_naming
branch
from
35ae15f to
aac3b90
Compare
mcsauder
force-pushed
the
vt_pusher_naming
branch
from
aac3b90 to
5c3861f
Compare
|
Closing this PR as there is currently no convenient method to migrate old parameter values to new parameter names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
This PR finishes work proposed in PR #11680 so that the PR can be merged/closed. The PR is straightforward renaming
VT_PSHER_RMP_DT->VT_PUSHER_RMP_DTI think we could give this PR a week and if it's not merged after that we could just close both PRs.
Additional context
See PR #11680
@RomanBapst , @sanderux
Thanks everyone!